Skip to content

Conversation

mondain
Copy link
Member

@mondain mondain commented May 22, 2025

Addresses tickets: #346 #366 #365
Provides a maximum await period for plugin startup when await is enabled
Allows by-pass for Red5 Pro to prevent additional configuration of awaitPlugins

@mondain mondain requested review from Andy--S, nateroe and Copilot May 22, 2025 20:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Addresses startup bugs and introduces a daemon update while addressing configuration for plugin initialization and bypass behavior for Red5 Pro.

  • Bumps dependency versions and parent pom versions from 2.0.17 to 2.0.18 across various modules
  • Updates the daemon’s classpath and service memory settings, as well as JVM options in the Windows batch installer
  • Reformulates the TomcatLoader’s startup logic by switching to virtual threads and incorporating a maximum 60-second wait for plugin readiness

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
servlet/pom.xml Parent version bumped to 2.0.18
service/src/main/daemon/red5 Updated daemon jar version and memory settings
service/src/main/daemon/install-service.bat Modified JVM options and increased maximum JVM memory
service/pom.xml Parent and commons-daemon version updated
server/src/main/server/red5.sh Updated JAVA_HOME recommendation version
server/src/main/server/conf/red5.properties Added await plugins configuration
server/src/main/server/conf/jee-container.xml Configured awaitPlugins property for Tomcat
server/src/main/java/org/red5/server/tomcat/TomcatLoader.java Modified await plugins logic and thread creation strategy
server/pom.xml Parent version bumped to 2.0.18
pom.xml Overall project version bumped to 2.0.18 and dependency updates
io/pom.xml Parent version bumped to 2.0.18
common/src/main/java/org/red5/server/api/Red5.java Version strings updated to 2.0.18
common/pom.xml Parent version bumped and dependency version updated
client/src/main/java/org/red5/client/Red5Client.java Version strings updated to 2.0.18
client/pom.xml Parent version bumped to 2.0.18
Comments suppressed due to low confidence (1)

server/src/main/java/org/red5/server/tomcat/TomcatLoader.java:227

  • [nitpick] The removal of the finally block that resets the thread name may affect thread identity used for debugging. Consider restoring the original thread name after the delayed start to maintain clarity in logging.
/* Removed finally block that resets the thread name */

@mondain mondain merged commit 5cf93fb into main May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants