build: Refactor gulpfiles from CJS to ESM #9149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pack" This is to avoid an issue due to "package" being a reserved word in JavaScript, and therefore not a valid export identifier.
cpcallen
added
component: build process
PR: chore
Collaborator
Author
|
This is now ready for review. |
gonfunko
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Prerequisite to PR #9146.
Proposed Changes
Migrate our gulpfiles (
gulpfile.jsandscripts/gulpfiles/*.js) from CommonJS to ECMAScript Module format.Reason for Changes
Will allow us to use
importto load thegoogle-closure-compilergulp plugin, as required for v20250609.0.0 of that module.Test Coverage
npm test.npm run buildverified to generate identical build product indist/.