Skip to content

Conversation

paulbrittain
Copy link
Contributor

  • Misc function doc updates & fixes as I read through code
  • Code change:lua/kubectl/utils/find.lua is_in_table() removed unused exact param
  • Code change: Set stdin param of vim.system call to nil instead of false - suggested by LSP (May be wrong?)

@mosheavni
Copy link
Collaborator

Nice work here thank you. Just fix @Ramilito comments :)

@paulbrittain paulbrittain force-pushed the chore/misc-docs-and-unused-param-removal branch from ccce1ba to f136d11 Compare October 9, 2024 06:12
@mosheavni
Copy link
Collaborator

also take a look at the type check that is failing:
https://github.com/Ramilito/kubectl.nvim/actions/runs/11249290844/job/31276754598?pr=439

…rsive is_in_table calls to not use `exact` match.
@paulbrittain
Copy link
Contributor Author

also take a look at the type check that is failing: https://github.com/Ramilito/kubectl.nvim/actions/runs/11249290844/job/31276754598?pr=439

Will do. How do you run the type check locally? :)

@Ramilito
Copy link
Owner

Ramilito commented Oct 9, 2024

also take a look at the type check that is failing: https://github.com/Ramilito/kubectl.nvim/actions/runs/11249290844/job/31276754598?pr=439

Will do. How do you run the type check locally? :)

Like this:

luarocks install luacheck
luacheck path/to/your/project

I must warn you that this isn't working 100% for me, I get some errors that are not triggering in my LSP nor in the github-action 😅

@paulbrittain
Copy link
Contributor Author

@Ramilito Hey Ramilito, yes the local linter doesn't return the same lint errors as the pipeline. Can the linting workflow be enabled so it runs on commits so that I can iterate on resolving the errors it returns commit-by-commit?

Is there a cost incurred per run?

@Ramilito
Copy link
Owner

@Ramilito Hey Ramilito, yes the local linter doesn't return the same lint errors as the pipeline. Can the linting workflow be enabled so it runs on commits so that I can iterate on resolving the errors it returns commit-by-commit?

Is there a cost incurred per run?

No costs yet so all good, there is a safeguard for all new contributors, probably to avoid denial of service attacks so I had to press a button to allow you to run workflows! Button pressed!

@paulbrittain
Copy link
Contributor Author

Ready for another workflow run :^)

@Ramilito
Copy link
Owner

LGTM! Awesome work @paulbrittain, if you are happy with it @mosheavni we can merge it!

@Ramilito Ramilito merged commit 34cdf3c into Ramilito:main Oct 12, 2024
1 check passed
@paulbrittain paulbrittain deleted the chore/misc-docs-and-unused-param-removal branch October 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants