-
-
Notifications
You must be signed in to change notification settings - Fork 13
chore: misc doc updates and remove unused exact
param from is_in_table
#439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: misc doc updates and remove unused exact
param from is_in_table
#439
Conversation
Nice work here thank you. Just fix @Ramilito comments :) |
ccce1ba
to
f136d11
Compare
also take a look at the type check that is failing: |
…rsive is_in_table calls to not use `exact` match.
Will do. How do you run the type check locally? :) |
Like this: luarocks install luacheck
luacheck path/to/your/project I must warn you that this isn't working 100% for me, I get some errors that are not triggering in my LSP nor in the github-action 😅 |
@Ramilito Hey Ramilito, yes the local linter doesn't return the same lint errors as the pipeline. Can the linting workflow be enabled so it runs on commits so that I can iterate on resolving the errors it returns commit-by-commit? Is there a cost incurred per run? |
No costs yet so all good, there is a safeguard for all new contributors, probably to avoid denial of service attacks so I had to press a button to allow you to run workflows! Button pressed! |
Ready for another workflow run :^) |
LGTM! Awesome work @paulbrittain, if you are happy with it @mosheavni we can merge it! |
lua/kubectl/utils/find.lua
is_in_table() removed unusedexact
paramstdin
param ofvim.system
call to nil instead of false - suggested by LSP (May be wrong?)