Skip to content

feat: add fetchAllAsync to builder #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

feat: add fetchAllAsync to builder #429

merged 2 commits into from
Oct 4, 2024

Conversation

Ramilito
Copy link
Owner

@Ramilito Ramilito commented Oct 4, 2024 •
edited
Loading

Implement fetchAllAsync to resourcebuilder and use that for getting all the api-resources at the same time.

@Ramilito Ramilito marked this pull request as ready for review October 4, 2024 20:56
@Ramilito Ramilito enabled auto-merge (squash) October 4, 2024 20:56
@Ramilito Ramilito disabled auto-merge October 4, 2024 20:56
@Ramilito Ramilito merged commit 8f87696 into main Oct 4, 2024
1 check passed
@Ramilito Ramilito changed the title feat: fetch api resources in a efficient way chore: fetch api resources in a efficient way Oct 4, 2024
@Ramilito Ramilito changed the title chore: fetch api resources in a efficient way feat: add fetchAllAsync to builder Oct 4, 2024
@mosheavni
Copy link
Collaborator

nice! did you check the difference of the execution time? is it significantly better?

@Ramilito
Copy link
Owner Author

Ramilito commented Oct 6, 2024 •
edited
Loading

Only the first two calls would have been impacted, since we did a fetch for the normal apis (/api/v1) then when that was done we would get the second group (/apis). getting the other stuff was done in a similar way since the fetchAllAsync basically just loops over a list and runs fetch_async.
This now does the first step at the same time.

@Ramilito Ramilito deleted the feat/fetch_api_resources_in_parrallel branch October 6, 2024 16:36
mosheavni pushed a commit to mosheavni/kubectl.nvim that referenced this pull request Oct 8, 2024
Squashed commit of the following:
5fe321b 
commit d216502
Author: Ramilito <[email protected]>
Date:   Tue Oct 8 09:42:12 2024 +0200

    fix: use name instead of cluster for header (Ramilito#437)

commit 66e060c
Author: Ramilito <[email protected]>
Date:   Mon Oct 7 17:12:42 2024 +0200

    fix: unload event on winclose (Ramilito#436)

commit 8f87696
Author: Ramilito <[email protected]>
Date:   Fri Oct 4 22:56:40 2024 +0200

    feat: fetch api resources in a efficient way (Ramilito#429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramilito @mosheavni