-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat/keep namespace filter #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ramilito
merged 14 commits into
Ramilito:main
from
mosheavni:chore/consolidate-config.json
Aug 24, 2024
Merged
feat/keep namespace filter #204
Ramilito
merged 14 commits into
Ramilito:main
from
mosheavni:chore/consolidate-config.json
Aug 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c7e1dc
to
f51d603
Compare
c47acbf
to
57a0425
Compare
Fixed! NS filter is working :) |
Ramilito
reviewed
Aug 23, 2024
Ramilito
reviewed
Aug 23, 2024
Ramilito
reviewed
Aug 23, 2024
mosheavni
commented
Aug 23, 2024
mosheavni
commented
Aug 23, 2024
Made 2 fixes from my phone |
Did a small refactor if you wanted to look at what I ment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save namespace filter to the
kubectl.json
filealso more elegant approach to saving a state to a file. we can reuse in the future.
Edit:
well.. sometimes it works, and sometimes it doesn't,
when it works it flashes between namespaced -> all -> namespaced
when it doesn't, it flashes namespaced -> all
which could cause epilepsy:
