Skip to content

Conversation

mosheavni
Copy link
Collaborator

@mosheavni mosheavni commented Aug 22, 2024

Save namespace filter to the kubectl.json file
also more elegant approach to saving a state to a file. we can reuse in the future.

Edit:
well.. sometimes it works, and sometimes it doesn't,
when it works it flashes between namespaced -> all -> namespaced
when it doesn't, it flashes namespaced -> all

which could cause epilepsy:
2024-08-23_02-04-06 (2)

@mosheavni mosheavni force-pushed the chore/consolidate-config.json branch from 4c7e1dc to f51d603 Compare August 22, 2024 22:19
@mosheavni mosheavni force-pushed the chore/consolidate-config.json branch from c47acbf to 57a0425 Compare August 22, 2024 22:48
@mosheavni mosheavni changed the title Chore/consolidate config.json feat/keep namespace filter Aug 22, 2024
@mosheavni
Copy link
Collaborator Author

Fixed! NS filter is working :)

@mosheavni mosheavni requested a review from Ramilito August 23, 2024 09:38
@mosheavni mosheavni requested a review from Ramilito August 23, 2024 09:46
@mosheavni
Copy link
Collaborator Author

Made 2 fixes from my phone
First time committing from mobile.
ahh... the technology nowadays...

@Ramilito Ramilito merged commit dac9c3b into Ramilito:main Aug 24, 2024
1 check passed
@Ramilito
Copy link
Owner

Did a small refactor if you wanted to look at what I ment!

@mosheavni mosheavni deleted the chore/consolidate-config.json branch August 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants