clapper-gtk: Add audio widget #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a base class called "ClapperGtkAv" and subclass it into "ClapperGtkVideo". This allows to have player and session inhibit logic in base class and share it with other subclassed widgets.
Actions of video widget are being deprecated in favour of the same actions in the recently added AV base class
A widget similar to video but for audio playback only. Widgets from ClapperGtk library like buttons, seek bar, etc. can be used in it for building an audio player with ease.
A simple audio player made using "ClapperGtkAudio" widget with python3 GI bindings
A detailed signal that allows for applications to receive element messages posted on the pipeline bus. Useful if app cares about some custom message that player normally does not handle. For example audio player might want to read "level" messages in order to show current audio level or implement visualizations.
We only need to post events in the pipeline for navigation to work. This was never used for anything and it generates a lot of noise in the pipeline bus when cursor is moving over video.
Replace all usage of "clapper_gtk_video_get_player" with "clapper_gtk_av_get_player" as the former one is deprecated
Replace all usage of "video" actions with "av" as the former one is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ClapperGtkAudiowidget which can be used to integrate audio-only playback to some application or just build an audio player with it.It made sense to make it, as it can easily work with all the buttons, seek bar, labels, etc. that
ClapperGtklibrary already provides.Usage is similar
ClapperGtkVideo- just place buttons inside it (or one of its children) and they will work automatically. This aims to be easy to use, yet at the same time gives freedom for applications to do the UI however they want to.Example is also included as part of this PR.
NOTE: This might do some breaking API changes for some bindings or apps, since the only way that made sense to do this was by subclassing video widget into a base class, moving some props to it and then having both audio and video widgets share that base class. I tried my best to reduce such issues to minimum.