Ability to show GStreamer pipeline #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to preview GStreamer pipeline while playing content. This makes it easier to check what is used underneath.
Pipeline preview creates temp files, so delete whole directory recursively on app exit. Since these files are used through launcher/portal with another app, we do not know when user finished using them, thus we cannot detect and remove them earlier.
Rafostar
force-pushed
the
pipeline-preview-launcher
branch
3 times, most recently
from
68ace17 to
63513f7
Compare
Needed for pipeline preview app functionality
System tmp directory does not work within containers such as Flatpak for our usage with file launcher, so make our own temp in app data dir
Rafostar
force-pushed
the
pipeline-preview-launcher
branch
from
63513f7 to
3663150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to preview GStreamer pipeline running underneath. It contains more data to help determine what exactly elements are used, what caps negotiated and where. Also helpful with debugging.
This implementation uses
GtkFileLauncher, so users can open image with some app of their choice (usually image viewer). Implementing whole image viewer as part of video player would be an overkill.This adds Graphviz as application dependency, but I made it in a way that app can be compiled without this functionality if this dependency gonna be inconvenient for some reason.