Thread trace triple buffering support for CDNA3/4 and RDNA4 #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApoKalipse-V
changed the title
ApoKalipse-V
changed the title
ApoKalipse-V
changed the title
ApoKalipse-V
commented
Oct 31, 2025
ApoKalipse-V
commented
Oct 31, 2025
vlaindic
requested changes
Nov 3, 2025
Member
vlaindic
left a comment
vlaindic
left a comment
There was a problem hiding this comment.
The 1st part of the review. I was primarily asking questions about the aqlprofile part, and would be great is someone more familiar would take a look.
vlaindic
requested changes
Nov 3, 2025
Member
vlaindic
left a comment
vlaindic
left a comment
There was a problem hiding this comment.
Some more comments. General idea looks fine to me.
projects/rocprofiler-sdk/source/include/rocprofiler-sdk/experimental/thread-trace/core.h
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/att-tool/profile_interface.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/att-tool/profile_interface.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk-tool/tool.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/aql/packet_construct.cpp
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/threading.cpp
Outdated
Show resolved
Hide resolved
ApoKalipse-V
force-pushed
the
gbaraldi/doublebuffer2
branch
2 times, most recently
from
9cc6782 to
611445a
Compare
ApoKalipse-V
changed the title
vlaindic
requested changes
Nov 4, 2025
Member
vlaindic
left a comment
vlaindic
left a comment
There was a problem hiding this comment.
Some minor comments. Otherwise, the overall implementation looks fine
projects/rocprofiler-sdk/source/include/rocprofiler-sdk/experimental/thread-trace/core.h
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/tests/producer_consumer.cpp
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/tests/producer_consumer.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/threading.cpp
Show resolved
Hide resolved
bing-ma
reviewed
Nov 4, 2025
Contributor
bing-ma
left a comment
bing-ma
left a comment
There was a problem hiding this comment.
The aqlprofile portion looks good to me. Left comments for some minor issues.
projects/aqlprofile/src/core/include/aqlprofile-sdk/aql_profile_v2.h
Outdated
Show resolved
Hide resolved
ApoKalipse-V
commented
Nov 4, 2025
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/tests/producer_consumer.cpp
Outdated
Show resolved
Hide resolved
bing-ma
approved these changes
Nov 4, 2025
Contributor
bing-ma
left a comment
bing-ma
left a comment
There was a problem hiding this comment.
The aqlprofile portion looks good to me.
vlaindic
approved these changes
Nov 5, 2025
Member
vlaindic
left a comment
vlaindic
left a comment
There was a problem hiding this comment.
Thanks for addressing comments! Minor comments about the tests and one question about the static scope. Otherwise, LGTM, so I approved.
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/dl.cpp
Outdated
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/tests/producer_consumer.cpp
Show resolved
Hide resolved
projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/thread_trace/tests/producer_consumer.cpp
Outdated
Show resolved
Hide resolved
ApoKalipse-V
force-pushed
the
gbaraldi/doublebuffer2
branch
from
53a82a4 to
d3698df
Compare
ApoKalipse-V
force-pushed
the
gbaraldi/doublebuffer2
branch
4 times, most recently
from
f9d8056 to
d23743b
Compare
ApoKalipse-V
force-pushed
the
gbaraldi/doublebuffer2
branch
from
d23743b to
b8cbe16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds triple buffering support for SQTT.
Limitations:
Technical Details
The aqlprofile implementation should work the any N buffers, however I have chosen triple buffering for the SDK as it appears to be a good tradeoff of memory use, lean way and easy of programming.
Test Plan
Test Result
Submission Checklist