cherry-pick 73af0ea to rocm-jaxlib-v0.6.0 #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujaykka
requested review from
JehandadKhan and
charleshofer
as code owners
|
@charleshofer I have cherry-picked 0555f1f onto this, it's a clean merge, but I didn't push yet because I wasn't sure if we really want to fix linting errors in bugfixes? |
fix to work with released ROCm 7.0.0 when using --rocm-version=7.0.0 The URL for the repo containing libdrm-amdgpu and friends has changed with ROCm 7. This commit adds support for the new URL scheme.
jujaykka
force-pushed
the
fix/rocm7-jaxlib0.6.0
branch
from
8ccc75e to
dfcddeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The URL for the repo containing libdrm-amdgpu and friends has changed with ROCm 7. This commit adds support for the new URL scheme.
Technical Details
Not a technical commit.
Test Plan & Result
Successfully ran ci_build for both the dist_wheels and build_dockers; resulting image can run jax.