Add version check to ROCm PJRT plugin #130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a version check to the PJRT wheel similar to the one added to the Plugin Wheel here
Technical Details
The module init file has been updated to parse the version of JAX and the PJRT wheel. If the version of the PJRT wheel is ahead of the JAX wheel, loading would fail. The behavior can be overridden with the
JAX_DEBUG_SKIP_ROCM_PLUGIN_VERSION_CHECKenv var.Test Plan
The change was tested by updating the versions of jax/jaxlib and then verifying the behavior of the plugin. Please note that the PJRT plugin is lazily loaded, meaning you have to access the device to trigger the behavior such as issuing
jax.devices()in a python shell.Test Result