Disable hipTensor examples on unsupported architectures #324
Conversation
Signed-off-by: zichguan-amd <[email protected]>
|
@zichguan-amd LGTM, though in the future, we should incorporate some autodetecting setup to avoid manual flags |
That would be ideal, I'll get hipTensor team to take a look and see if they have any opinions on this. |
|
Hi @cgmillette, is there any recommendations from hipTensor? |
|
Adding the owners of hipTensor, @Ryker0627 and @evedovelli. |
| enable_language(${ROCM_EXAMPLES_GPU_LANGUAGE}) | ||
|
|
||
| # see https://rocm.docs.amd.com/projects/hipTensor/en/latest/install/installation.html#gpu-support | ||
| set(HIPTENSOR_SUPPORTED_ARCH gfx908 gfx90a gfx942 gfx950) |
There was a problem hiding this comment.
Ideally this list of supported arch should be set by hipTensor, and you could just lookup for the value here, right after the find_package(hiptensor), so when new architectures are supported, no changes are needed here.
I'm creating an internal ticket for hipTensor for us to provide this.
There was a problem hiding this comment.
Do you have any ETA for that? Or should I go ahead and merge the PR for now?
There was a problem hiding this comment.
Go ahead and merge it, so you don't get blocked. Once it's done I can let you know, so you can change the examples, or I can submit a PR for the examples myself.
There was a problem hiding this comment.
Sounds good thanks!
Signed-off-by: zichguan-amd <[email protected]>
Signed-off-by: zichguan-amd <[email protected]>
Signed-off-by: zichguan-amd <[email protected]>
Signed-off-by: zichguan-amd <[email protected]>
4 participants
Motivation
hipTensor only support gfx9, see https://rocm.docs.amd.com/projects/hipTensor/en/latest/install/installation.html#gpu-support.
Technical Details
Don't build hipTensor examples if
CMAKE_HIP_ARCHITECTUREScontains anything not gfx9.Test Plan
Build and run ctest on gfx1100
Test Result
hipTensor examples are not build by default on gfx1100 and are not built unless
-DCMAKE_HIP_ARCHITECTURESis set to only contain gfx9 architectures.Submission Checklist