Add HIP Graph API tutorial #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

j-stephan merged 62 commits into ROCm:amd-staging from j-stephan:hip-graph-tutorial

Oct 15, 2025

+4,067 −7

Contributor

j-stephan commented Aug 21, 2025

Motivation

This PR (once complete) will add tutorial code to the repository. It will showcase the HIP graph API with an image processing pipeline for the FDK backprojection algorithm.

Technical Details

Adds an image processing pipeline and shows how to asynchronously execute it using HIP streams, the HIP graph capturing API and the HIP graph creation API.

Test Plan

While it is a tutorial code, the code functions as a test itself.

Test Result

N/A

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

j-stephan requested a review from neon60

August 21, 2025 16:19

j-stephan self-assigned this

j-stephan force-pushed the hip-graph-tutorial branch 2 times, most recently from 9c1afd9 to 702a2d2 Compare

August 27, 2025 15:08

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/backprojection.hip Outdated Show resolved Hide resolved

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/backprojection.hip Outdated Show resolved Hide resolved

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/log_transform.hip Show resolved Hide resolved

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/weighting.hip Show resolved Hide resolved

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/weighting.hip Show resolved Hide resolved

j-stephan force-pushed the hip-graph-tutorial branch from 9d24660 to ba11965 Compare

September 4, 2025 08:33

j-stephan changed the title ~~Add stream-based prototype for FDK backprojection tutorial~~ Add FDK backprojection tutorial

j-stephan force-pushed the hip-graph-tutorial branch 7 times, most recently from 2ca59c4 to d4e247c Compare

September 22, 2025 14:44

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/main_graph_creation.hip Outdated Show resolved Hide resolved

neon60 reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/src/main_graph_creation.hip Outdated Show resolved Hide resolved

j-stephan force-pushed the hip-graph-tutorial branch 2 times, most recently from 3671071 to 98d5545 Compare

October 1, 2025 13:19

j-stephan changed the title ~~Add FDK backprojection tutorial~~ Add HIP Graph API tutorial

j-stephan added 7 commits

October 10, 2025 11:29


          Add stream-based prototype

66efa4c

Signed-off-by: Jan Stephan <[email protected]>


          Add graph-capturing prototype

76c7808

Signed-off-by: Jan Stephan <[email protected]>


          Refactoring and geometry fixes

e3549f8

Signed-off-by: Jan Stephan <[email protected]>


          Disable graph capture tutorial on Windows

1586d52

Signed-off-by: Jan Stephan <[email protected]>


          Graph creation and smaller fixes

b0be7aa

Signed-off-by: Jan Stephan <[email protected]>


          Address review comments

Signed-off-by: Jan Stephan <[email protected]>


          CMake fixes

80210d4

Signed-off-by: Jan Stephan <[email protected]>


          Support GPUs without texture instructions

f0d5c2e

Signed-off-by: Jan Stephan <[email protected]>

j-stephan force-pushed the hip-graph-tutorial branch from b52920e to f0d5c2e Compare

October 10, 2025 11:08


          Explicitly install git

3d5a7e6

Signed-off-by: Jan Stephan <[email protected]>

j-stephan marked this pull request as ready for review

October 10, 2025 12:41

j-stephan requested review from a team as code owners

October 10, 2025 12:41

j-stephan requested a review from zichguan-amd

October 10, 2025 12:41

j-stephan added 16 commits

October 10, 2025 15:34


          Explicitly install hipFFT

Signed-off-by: Jan Stephan <[email protected]>


          Install libTIFF

827497c

Signed-off-by: Jan Stephan <[email protected]>


          Print duration.count() instead of duration

b75d5fa

Signed-off-by: Jan Stephan <[email protected]>


          Remove <omp.h>

d0bcb10

Signed-off-by: Jan Stephan <[email protected]>


          Enable separable compilation and remove link to hip::host

Signed-off-by: Jan Stephan <[email protected]>


          Mirror hipFFT examples lookup of libraries and flags

44b313e

Signed-off-by: Jan Stephan <[email protected]>


          Always use CONFIG mode for find_package

fea6fdb

Signed-off-by: Jan Stephan <[email protected]>


          Ensure CMake understands we want to compile for NVIDIA

976d2d0

Signed-off-by: Jan Stephan <[email protected]>


          Next try

72842c2

Signed-off-by: Jan Stephan <[email protected]>


          Compile with warnings and add CUDA helpers

ff0fa26

Signed-off-by: Jan Stephan <[email protected]>


          Correct hipStreamWaitEvent signature

Signed-off-by: Jan Stephan <[email protected]>


          Enforce NVIDIA

99d42a5

Signed-off-by: Jan Stephan <[email protected]>


          More CUDA fixes

1cd6520

Signed-off-by: Jan Stephan <[email protected]>


          Link to CUDA driver

2a06455

Signed-off-by: Jan Stephan <[email protected]>


          Remove obsolete TIFF handling

6fe57d3

Signed-off-by: Jan Stephan <[email protected]>


          Fix remaining warnings

a0d6db0

Signed-off-by: Jan Stephan <[email protected]>

j-stephan mentioned this pull request

[Ex CI] Add libtiff-dev, libopencv-dev and rpp ROCm/ROCm#5512

Merged

1 task


          LibTIFF cleanup

Signed-off-by: Jan Stephan <[email protected]>

zichguan-amd reviewed

View reviewed changes

HIP-Doc/Tutorials/graph_api/README.md Show resolved Hide resolved


          Add Windows note

f1cfe9f

Signed-off-by: Jan Stephan <[email protected]>

zichguan-amd approved these changes

View reviewed changes

Collaborator

zichguan-amd left a comment

LGTM, thanks!

j-stephan merged commit ef24264 into ROCm:amd-staging

33 checks passed

j-stephan deleted the hip-graph-tutorial branch

October 15, 2025 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet