Count test totals correctly for dashboards #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested review from
mrodden,
JehandadKhan,
Ruturaj4 and
zahiqbal
mrodden
reviewed
Mar 14, 2025
Co-authored-by: Mathew Odden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling
pytestJSON reports, exclude skipped tests from the total number of tests run. This is in support of the dashboarding effort and makes calculating the passing test rate with the expression100.0 * passed / unskipped_totalpossible. Also adds the option to skip this feature and compute totals as normal with theROCM_TEST_INCLUDE_SKIPSenvironment variable.From here on out, we should use
pytest.mark.xfailorpytest.mark.xfail(run=False)to "skip" failing tests.