Change the workflow for opening upstream PRs to post links that open PRs #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
force-pushed
the
gh-9948-fix-upstream-pr
branch
from
5d9f205 to
6963f3a
Compare
Ruturaj4
added a commit
that referenced
this pull request
Mar 18, 2025
* Add workflow for nightly pull from upstream * Only run on weekdays * Fix yaml checker * Set runners for ROCM * Allow devs to kick off sync job manually (#119) * Unpin container in CI build and remove libssl-dev install * Rename the CI flow to 'ROCm CI' and only run it on PRs to rocm-main (#126) * Rename the CI flow to 'ROCm CI' and only run it on PRs to the rocm-main branch * Change name to 'ROCm CPU CI' * Fix nightly sync permissions (#124) * Add GHA workflow for opening PRs upstream (#116) * Add file for opening PRs upstream * Add HEAD_REF as environment variable * Fill out code for making a new branch and opening a PR to upstream * Add names for steps * Fix yaml * Fix yaml again * Leave a comment on the old PR linking to the new one * Add proper permissions for creating banches and opening PRs * Fix YAML * Create a new branch when merging upstream main to rocm-main (#128) * Fix upstream sync checkout (#130) * Checkout main before trying to switch to it * Fix the checkout command * Add git fetch (#132) * Fix debug_nans false positive in jnp.quantile * Remove some obsolete deprecation registrations PiperOrigin-RevId: 693793727 * Update XLA dependency to use revision http://github.com/openxla/xla/commit/0f6331b1881ae34c8b1cd59580900d556bc8305c. PiperOrigin-RevId: 693819727 * Adding start index and kv_seq_len to decode kernel * Add workflow for nightly pull from upstream * Only run on weekdays * Fix yaml checker * Set runners for ROCM * Allow devs to kick off sync job manually (#119) * Unpin container in CI build and remove libssl-dev install * Rename the CI flow to 'ROCm CI' and only run it on PRs to rocm-main (#126) * Rename the CI flow to 'ROCm CI' and only run it on PRs to the rocm-main branch * Change name to 'ROCm CPU CI' * Fix nightly sync permissions (#124) * Add GHA workflow for opening PRs upstream (#116) * Add file for opening PRs upstream * Add HEAD_REF as environment variable * Fill out code for making a new branch and opening a PR to upstream * Add names for steps * Fix yaml * Fix yaml again * Leave a comment on the old PR linking to the new one * Add proper permissions for creating banches and opening PRs * Fix YAML * Create a new branch when merging upstream main to rocm-main (#128) * Fix upstream sync checkout (#130) * Checkout main before trying to switch to it * Fix the checkout command * Fix FFI example test in CI * Add commit to see if it triggers CI * Make daily sync permissions at the workflow level and fix merge CI (#143) * Longer timeout for doc render * Fix upstream PR workflow to use origin branches (#151) * Add token for GitHub CLI (#152) * Change the workflow for opening upstream PRs to post links that open PRs (#157) * Add GH auth token to env * Make the job post a comment with a link to open the PR instead of actually opening the PR * Fix rebase command to exclude rocm-main (#158) * Fix user identity for rebase (#159) * Fix the link to the downstream PR (#160) * Use the reference format for links instead of inline (#162) * Update ci-build.yaml to use specific image * Update ci-build.yaml * Don't look for CUDA files when building the ROCm wheel (#173) * GH 9948: Automerge daily sync PRs (#181) * Run CPU CI again * Add upload wheels file for pypi (#184) * Change to trigger CI * Skip failing tests * Skip one more test * Add GPU CI (#137) * Commit to trigger CI * Add option to ci_build to run different tests * Only run core tests for CI * Quote test command in workflow file * Add dev guide (#188) * Use hipfft XLA fix * Skip PallasCallRemoteDMAInterpretTest.test_interpret_remote_dma_ppermute for failing on ROCm * Reduce pytest threads * Remove conflicting param for ci_build * Run GPU CI on PRs destined for QA branches (#228) * Change to make CI run * Use a GitHub app for syncing rocm-main and upstream main (#224) * Add CODEOWNERS file (#236) * Use bazel for PR tests (#216) * Use bazel for running pre-merge CI tests * Don't use HEREDOC * Fix block text * Use bash array * Add bazel install * Put Bazel in the build image * Use Bazelisk * Remove bazel install in Docker * Go back to upstream XLA * Remove bazel test command from workflow * Move test command to build container * Fix string format typos * Change CODEOWNERS (#237) * Install numa library * Fix numa package * Fix numactl-devel name * Fix auditwheel version issue (#288) Auditwheel 6.3.0 changed/removed the lddtree function so cap constraint to 6.2.x --------- Co-authored-by: JD <[email protected]> Co-authored-by: Jake VanderPlas <[email protected]> Co-authored-by: Jake VanderPlas <[email protected]> Co-authored-by: jax authors <[email protected]> Co-authored-by: Robert Dyro <[email protected]> Co-authored-by: GitHub Actions <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ruturaj Vaidya <[email protected]> Co-authored-by: Mathew Odden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a slight change from the original design where Actions would open up a new PR to upstream once someone labeled a PR with the
open-upstreamlabel. The job still creates the proper feature branch. However, because Actions can only perform operations on this repo (not the upstream repo) and because we want PRs to be authored by our team members (and not our CI), we need devs to actually open the upstream PR themselves.Instead of having Actions open up the PR, Actions will now post a comment with a link to open the PR to upstream that auto-fills the PR fields.
Story: https://github.com/ROCm/frameworks-internal/issues/9948