[main] Add manylinux2_28 to wheel names #77
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manywheel/build_common.sh
Outdated
| fi | ||
|
|
||
| # zip up the wheel back | ||
| zip -rq $(basename $pkg) $PREIX* |
There was a problem hiding this comment.
This needs to go
Also the lines below need to move into the if/else condition above:
# replace original wheel
rm -f $pkg
mv $(basename $pkg) $pkg
manywheel/build_common.sh
Outdated
Comment on lines
207
to
208
| wheel_file=$(basename "$pkg" | sed -e 's/-cp.*$/.dist-info\/WHEEL/') | ||
| sed -i -e "s#linux_x86_64#${PLATFORM}#" "$wheel_file" |
manywheel/build_common.sh
Outdated
| wheel_file=$(basename "$pkg" | sed -e 's/-cp.*$/.dist-info\/WHEEL/') | ||
| sed -i -e "s#linux_x86_64#${PLATFORM}#" "$wheel_file" | ||
|
|
||
| zip -rq "$(basename "$pkg" | sed -e "s#linux_x86_64#${PLATFORM}#")" "${PREFIX}"* |
There was a problem hiding this comment.
Alternate idea: assign $pkg to $("$pkg" | sed -e "s#linux_x86_64#${PLATFORM}#") so that all the command after can keep referring to $pkg. Not sure if it messes with the iterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting changes from pytorch/pytorch#141988
http://rocm-ci.amd.com/job/mainline-pytorch2.7-manylinux-wheels/221/
http://rocm-ci.amd.com/job/mainline-pytorch2.7-manylinux-wheels/286/