Skip to content

Add receipt for pytorch #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add receipt for pytorch #791

wants to merge 2 commits into from

Conversation

alugorey
Copy link

@alugorey alugorey commented Aug 8, 2025

The current "combined" api receipt includes batch_prefill variant. Pytorch does not support this (yet). Creating a new receipt that removes the BATCH_PREFILL variant for a new receipt 6. This change should not cause any regression as it's a path only hit when the receipt for fwd kernel generation is set to 6. Currently only used by PyTorch.

@alugorey alugorey requested review from Copilot and slippedJim and removed request for Copilot August 8, 2025 16:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new receipt variant (receipt 6) for PyTorch that excludes the BATCH_PREFILL API variant, which is currently unsupported by PyTorch.

  • Adds receipt 6 that includes only COMBINED_API and FMHA_FWD_SPLITKV_API variants
  • Removes FMHA_BATCH_PREFILL_API from the new receipt to accommodate PyTorch limitations

@alugorey alugorey requested a review from valarLip August 8, 2025 16:20
Copy link
Collaborator

@valarLip valarLip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alugorey
Copy link
Author

alugorey commented Aug 9, 2025

@pytorchbot merge

Copy link
Contributor

@slippedJim slippedJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants