-
Couldn't load subscription status.
- Fork 111
Adding rocprofiler-compute #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
requirements.txt
Outdated
| plotext | ||
| plotille | ||
| pymongo | ||
| pyyaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyyaml is cited earlier in the list.
It is preferred that some version restrictions are set for each dependency to have more control in the environment across different OS distros and python versions.
Is this entire list of modules required for build time? If so, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyyaml is cited earlier in the list.
Oh good catch, the casing was different in the compute declaration so I must have missed that when removing duplicates. I removed the duplicate entry here.
It is preferred that some version restrictions are set for each dependency to have more control in the environment across different OS distros and python versions.
I reached out to the compute team to ask about version restrictions. This can be looked into next week, but it seems like version restrictions was not something that has been considered too much from their end.
Is this entire list of modules required for build time? If so, why?
When trying to build compute with TheRock, we get the following mandatory check that checks Python packages before building.
[rocprofiler-compute configure] -- Checking for required Python package dependencies...
[rocprofiler-compute configure] -- astunparse = yes
[rocprofiler-compute configure] -- colorlover = yes
[rocprofiler-compute configure] -- dash_bootstrap_components = yes
[rocprofiler-compute configure] -- dash_svg = yes
[rocprofiler-compute configure] -- dash = yes
[rocprofiler-compute configure] -- kaleido = yes
[rocprofiler-compute configure] -- matplotlib = yes
[rocprofiler-compute configure] -- numpy = yes
[rocprofiler-compute configure] -- pandas = yes
[rocprofiler-compute configure] -- plotext = yes
[rocprofiler-compute configure] -- plotille = yes
[rocprofiler-compute configure] -- pymongo = yes
[rocprofiler-compute configure] -- pyyaml = yes
[rocprofiler-compute configure] -- setuptools = yes
[rocprofiler-compute configure] -- sqlalchemy = yes
[rocprofiler-compute configure] -- tabulate = yes
[rocprofiler-compute configure] -- textual = yes
[rocprofiler-compute configure] -- textual_plotext = yes
[rocprofiler-compute configure] -- Skipping check for textual_fspicker
[rocprofiler-compute configure] -- tqdm = yes
[rocprofiler-compute configure] -- OK: Python dependencies available in current environment.
I can double check with the compute team about this, but I would assume this is a strict requirement if it's necessary to build. If any are missing, it errors out.
Motivation
Add
rocprofiler-computeto TheRock buildTechnical Details
CMakeLists.txtunder theprofilerdirectoryrocprofiler-computewiththerock_cmake_subproject_declare()rocprofiler-computewiththerock_provide_artifact()callartifact-rocprofiler-compute.tomlto provide artifacts forrocprofiler-computerocprofiler-computedependencies to the root levelrequirements.txtrocprofiler-computecorrespondingrequirements.txtfile.Test Plan
Ensure that
rocprofiler-computeis being added to TheRock, build passes locallyTest Result
Local build adds binaries from rocprofiler-compute to its corresponding
/stagedirectorySubmission Checklist