Skip to content

Conversation

@mpashkovskii
Copy link

No description provided.

@zstreet87
Copy link
Collaborator

@mpashkovskii this code looks okay but can I get more context for this change? What is the motivation for this modification?

@mpashkovskii
Copy link
Author

@zstreet87 Megatron-LM serving code doesn't work with expert parallelism (EP). EP is the most performant option for MoE models.

Copy link
Collaborator

@zstreet87 zstreet87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zstreet87
Copy link
Collaborator

can merge after CI reports green.

@zstreet87 zstreet87 merged commit 2bfccb4 into ROCm:rocm_dev May 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants