Skip to content

Conversation

@mpashkovskii
Copy link

No description provided.

Copy link
Collaborator

@lcskrishna lcskrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcskrishna
Copy link
Collaborator

@mpashkovskii are the CI failures related to this one? can you check

@mpashkovskii
Copy link
Author

@lcskrishna,it is not related to the code change. It is related to the infrastructure if I read the error message correctly.

@jasainio
Copy link

@lcskrishna can this be merged?

@zstreet87
Copy link
Collaborator

everything has passed @wenchenvincent and @lcskrishna please merge

@lcskrishna lcskrishna merged commit a320613 into ROCm:rocm_dev May 6, 2025
3 checks passed
Vmjkom pushed a commit to Vmjkom/Megatron-LM that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants