Revert "[BUG] [CONV] Fix incorrect stride calculation when w=1/h=1 in… #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanLichtnerAMD
requested review from
BradPepersAMD,
BrianHarrisonAMD and
adickin-amd
as code owners
BrianHarrisonAMD
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
LGTM, but should get @SreecharanGundaboluAMD to double check.
BradPepersAMD
approved these changes
Jun 24, 2025
SreecharanGundaboluAMD
approved these changes
Jun 24, 2025
|
Okay, the CI has been running since 8:00 am and is still not finished. I think we're short of MI100 machines :( I'm going to merge this, since we need a fix ASAP so we can start CI on the PR to update the CK hash for staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… MISA solvers (#3786)"
This reverts commit 8ad3741.