Skip to content

Conversation

@ikrispin
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary:

The changes in application.properties update Quarkus REST client configurations. The most significant issue is the continued use of insecure TLS settings, which should be addressed, especially for production environments.


File: src/main/resources/application.properties

  • Issue: Security - Insecure TLS Configuration
    • quarkus.rest-client.osh-api.tls-trust-all=true and quarkus.rest-client.osh-api.verify-host=false disable critical SSL/TLS certificate validation. This makes the application vulnerable to Man-in-the-Middle (MITM) attacks and should never be used in a production environment.
    • Suggestion: For production, these properties must be removed or set to false (implicitly or explicitly) to enable proper certificate validation. If this is intended for a specific development or testing environment (e.g., self-signed certificates), consider moving these settings to an environment-specific profile (e.g., application-dev.properties) and adding a clear comment explaining the security implications.
  • Clarity: The change from trust-all to tls-trust-all seems to be a key rename. Assuming this is a necessary Quarkus upgrade or correction, it's fine.
  • Clarity: Adding quarkus.rest-client.osh-api.follow-redirects=true is generally a reasonable default for REST clients.

@sonarqubecloud
Copy link

@ikrispin ikrispin merged commit df09ee5 into main Nov 18, 2025
3 checks passed
@ikrispin ikrispin deleted the osh-allow-redirect branch November 18, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants