Skip to content

Conversation

@ikrispin
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File: src/main/resources/application.properties

Issue Comment:

The addition of quarkus.rest-client.osh-api.trust-all=true and quarkus.rest-client.osh-api.verify-host=false is a significant security concern. These settings disable SSL/TLS certificate validation and hostname verification for the osh-api REST client.

  • Security Risk: Disabling these checks makes the application vulnerable to Man-in-the-Middle (MITM) attacks, allowing an attacker to intercept, read, and modify communications with the OSH API without detection.
  • Best Practice: In a production environment, trust validation and hostname verification are critical security controls. Certificates should always be properly validated against a trusted certificate authority (CA).

Suggestion:

  • Remove these properties for production deployments.
  • If these are required for a specific non-production environment (e.g., local development with self-signed certificates or specific testing scenarios), ensure they are conditionally enabled only for those profiles (e.g., application-dev.properties or application-test.properties).
  • For any environment, the preferred and secure approach is to properly configure a trust store with the necessary certificates if the OSH API uses non-standard or internal CAs, rather than disabling security checks entirely.

@sonarqubecloud
Copy link

@ikrispin ikrispin merged commit b825e11 into main Nov 18, 2025
3 checks passed
@ikrispin ikrispin deleted the disable-ssl-dev branch November 18, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants