Skip to content

Add sources to Subject data class #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpgxvii merged 4 commits into from
Mar 31, 2025
Merged

Add sources to Subject data class #77

mpgxvii merged 4 commits into from
Mar 31, 2025

Conversation

@mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Mar 27, 2025 •
edited
Loading

  • When the subject gets updated with new attributes the source property is empty which causes source deletion in MP, this adds sources to the Subject class
  • Updated Subject externalId and externalLink to string
  • Added Organization serializer for requests back to MP

Solves #76

afolarin
afolarin approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@afolarin afolarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpgxvii mpgxvii merged commit 349cb5a into dev Mar 31, 2025
4 checks passed
@mpgxvii mpgxvii deleted the fix/attributes branch March 31, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afolarin afolarin afolarin approved these changes

@yatharthranjan yatharthranjan Awaiting requested review from yatharthranjan yatharthranjan is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpgxvii @afolarin