Skip to content

Fix missing serverName value for app-config #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keyvaann merged 1 commit into from
Oct 4, 2024
Merged

Fix missing serverName value for app-config #330

keyvaann merged 1 commit into from
Oct 4, 2024

Conversation

@pvannierop
Copy link
Contributor

@pvannierop pvannierop commented Oct 4, 2024

This PR will fix the missing serverName value for app-config. This caused the return URL to contain localhost.

@pvannierop pvannierop requested a review from keyvaann October 4, 2024 07:26
@pvannierop pvannierop self-assigned this Oct 4, 2024
keyvaann
keyvaann approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit 5eb99a4 into dev Oct 4, 2024
@keyvaann keyvaann deleted the bugfix/app-config-servername branch October 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyvaann keyvaann keyvaann approved these changes

Assignees

@pvannierop pvannierop

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pvannierop @keyvaann