minor config update in realtime dashboard #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatharthranjan
approved these changes
Mar 29, 2023
Member
yatharthranjan
left a comment
yatharthranjan
left a comment
There was a problem hiding this comment.
LGTM, though change the base branch to dev instead of main.
keyvaann
reviewed
Mar 29, 2023
| set: | ||
| - name: kafka_num_brokers | ||
| value: {{ .Values.kafka_num_brokers }} | ||
| - name: jdbc.username |
Collaborator
There was a problem hiding this comment.
I think I've seen this change before, was it in this component or JDBC connector?
Member
Author
There was a problem hiding this comment.
Not sure. I think it is jdbc.user in jdbc-connector but jdbc.username in jdbc-connector-agg
Member
Author
|
should I go ahead and merge it? |
Member
|
I think yeah go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Found
jdbc.usernameis not the correct config in40-realtime-dashboard.yamlfile while testing dashboard. Changed it tojdbc.user. Otherwise, the dashboard is working alright.Benefits
NA
Possible drawbacks
NA
Applicable issues
NA
Additional information