Minor updates on realtime dashboards #230
Conversation
|
Hi, @K1Hyve, I am getting this error in CI
Not sure how can I add me ssh keys there. |
etc/base.yaml.gotmpl
Outdated
| #*/}} | ||
|
|
||
|
|
||
| ksql_server: |
There was a problem hiding this comment.
Maybe comment this out similar to the appserver one above (with explanation) since ksql-server is disabled by default.
etc/base.yaml.gotmpl
Outdated
| #ksql_server: | ||
| # ksql: | ||
| # queries: | | ||
| # {{- readFile "cp-ksql-server/queries.sql" | nindent 8 }} |
There was a problem hiding this comment.
You also need to comment within the braces as well (same as others above)
{{/*
....
*/}}
Otherwise, it causes issues with go templating.
There was a problem hiding this comment.
oh alright, will do that.
|
@blootsvoets @K1Hyve, do you think any changes are needed or should I go ahead and merge it? |
|
From the repository perspective looks good to me. I can't say from application view point. |
|
@Hsankesara lets merge. We are going to be the first users of this anyways, so can fix it if we find any issues in testing. |
Description of the change
Chart version updates and minor changes in the real-time dashboards.
Benefits
N/A
Possible drawbacks
N/A
Applicable issues
N/A
Additional information