-
Notifications
You must be signed in to change notification settings - Fork 12
release 1.0.0 - hosting all helm charts #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
24f49ef to
c4c5213
Compare
c4c5213 to
09f9fba
Compare
|
Nice work @blootsvoets - hopefully will help guarantee "versions" of |
|
Hi, does this fix #197 ? |
Fixes radar-appserver deployment
|
@iDmple yes this should fix that issue. |
33c2d75 to
2611fb8
Compare
| If you are installing `radar-appserver`, please add your Google Firebase credentials to `etc/radar-appserver/google-credentials.json`. Please see example file for the format. This file can be downloaded from your Firebase account. | ||
| If you are installing `radar-appserver`, it needs to be authorized with the Google Firebase also used by the aRMT / Questionnaire app. In Firebase, go to _Project settings_ -> _Service accounts_ and download a Firebase Admin SDK private key. Store the generated key as `etc/radar-appserver/firebase-adminsdk.json`. | ||
|
|
||
| ## Upgrade instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added upgrade instructions here. I'm wondering whether this is obvious enough. Perhaps if we call this version 1.0.0, I can say upgrade from RADAR-Kubernetes prior to version 1.0.0.
| If you are installing `radar-appserver`, please add your Google Firebase credentials to `etc/radar-appserver/google-credentials.json`. Please see example file for the format. This file can be downloaded from your Firebase account. | ||
| If you are installing `radar-appserver`, it needs to be authorized with the Google Firebase also used by the aRMT / Questionnaire app. In Firebase, go to _Project settings_ -> _Service accounts_ and download a Firebase Admin SDK private key. Store the generated key as `etc/radar-appserver/firebase-adminsdk.json`. | ||
|
|
||
| ## Upgrade instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks complicated, there is probably no simple workaround for it now but I hope we fix make this simpler in future.
| - events: ["presync"] | ||
| showlogs: true | ||
| command: "kubectl" | ||
| args: ["--context", "{{ .Values.kubeContext }}", "apply", "--force-conflicts", "--server-side", "-f", "../etc/kube-prometheus-stack/files/crds.yaml"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will solve issues in case Prometheus haven't been cleanly installed or uninstalled before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, prometheus cannot install updates without the updated CRDs, and it does not automatically update the CRDs itself.
keyvaann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@blootsvoets Can we add a table of content section on the README? Since it is very long, new users may miss the important topics. |
Update to bitnami minio
|
I've added a table of contents. Note that a table of contents is always available via a top-left button on the README, as described in https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/. |
release 1.0.0 - hosting all helm charts
Updated the external helm dependencies to use the versions published in RADAR-base/radar-helm-charts#33 instead of the external repositories.
The values files in
etchave been minimised to only contain values that deviate from the default value or that are likely to change.Tasks
Pending release of kube-prometheus-stack 0.3.0.