Skip to content

Conversation

@blootsvoets
Copy link
Contributor

@blootsvoets blootsvoets commented Jul 6, 2022

Updated the external helm dependencies to use the versions published in RADAR-base/radar-helm-charts#33 instead of the external repositories.

The values files in etc have been minimised to only contain values that deviate from the default value or that are likely to change.

Tasks

  • document upgrade instructions (if relevant).
  • test installing on a new cluster with K8S 1.23.
  • test installing on an existing cluster.

Pending release of kube-prometheus-stack 0.3.0.

@blootsvoets blootsvoets force-pushed the internal-chart-version branch from 24f49ef to c4c5213 Compare July 6, 2022 12:00
@blootsvoets blootsvoets force-pushed the internal-chart-version branch from c4c5213 to 09f9fba Compare July 6, 2022 12:03
@afolarin
Copy link
Member

afolarin commented Jul 6, 2022

Nice work @blootsvoets - hopefully will help guarantee "versions" of production.yaml deploy

@iDmple
Copy link

iDmple commented Jul 8, 2022

Hi, does this fix #197 ?

@keyvaann
Copy link
Collaborator

@iDmple yes this should fix that issue.

@blootsvoets blootsvoets force-pushed the internal-chart-version branch from 33c2d75 to 2611fb8 Compare July 18, 2022 09:34
If you are installing `radar-appserver`, please add your Google Firebase credentials to `etc/radar-appserver/google-credentials.json`. Please see example file for the format. This file can be downloaded from your Firebase account.
If you are installing `radar-appserver`, it needs to be authorized with the Google Firebase also used by the aRMT / Questionnaire app. In Firebase, go to _Project settings_ -> _Service accounts_ and download a Firebase Admin SDK private key. Store the generated key as `etc/radar-appserver/firebase-adminsdk.json`.

## Upgrade instructions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added upgrade instructions here. I'm wondering whether this is obvious enough. Perhaps if we call this version 1.0.0, I can say upgrade from RADAR-Kubernetes prior to version 1.0.0.

@blootsvoets blootsvoets marked this pull request as ready for review July 18, 2022 09:39
If you are installing `radar-appserver`, please add your Google Firebase credentials to `etc/radar-appserver/google-credentials.json`. Please see example file for the format. This file can be downloaded from your Firebase account.
If you are installing `radar-appserver`, it needs to be authorized with the Google Firebase also used by the aRMT / Questionnaire app. In Firebase, go to _Project settings_ -> _Service accounts_ and download a Firebase Admin SDK private key. Store the generated key as `etc/radar-appserver/firebase-adminsdk.json`.

## Upgrade instructions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks complicated, there is probably no simple workaround for it now but I hope we fix make this simpler in future.

- events: ["presync"]
showlogs: true
command: "kubectl"
args: ["--context", "{{ .Values.kubeContext }}", "apply", "--force-conflicts", "--server-side", "-f", "../etc/kube-prometheus-stack/files/crds.yaml"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will solve issues in case Prometheus haven't been cleanly installed or uninstalled before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, prometheus cannot install updates without the updated CRDs, and it does not automatically update the CRDs itself.

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivemaham
Copy link
Contributor

@blootsvoets Can we add a table of content section on the README? Since it is very long, new users may miss the important topics.

@blootsvoets
Copy link
Contributor Author

I've added a table of contents. Note that a table of contents is always available via a top-left button on the README, as described in https://github.blog/changelog/2021-04-13-table-of-contents-support-in-markdown-files/.

@keyvaann keyvaann merged commit 2ceb707 into main Nov 3, 2022
@blootsvoets blootsvoets deleted the internal-chart-version branch November 3, 2022 10:35
blootsvoets pushed a commit that referenced this pull request Dec 21, 2022
release 1.0.0 - hosting all helm charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants