fix bug: INTEL XEON 4510's fpstates capacity size is over 2 pages #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about making this model specific i.e. conditional compiling or configurable |
I don't think it worth doing that. All latest data center Intel cpu has very big fpstates capacity size. I would assume this is also the case for latest AMD data center CPUs. |
|
-- if there is no regression on desktop chips (i.e. single page fpstate). I wonder if there is a hardcoded size in the low-level code somewhere. Would you do a regression test? |
I will try to find a old machine to do a test this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.