Skip to content

Fixed: Cache is not cleaned and some data is deleted incorrectly when using cleaner module. #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

Fixed: Cache is not cleaned and some data is deleted incorrectly when using cleaner module. #1417

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9b08a6
Fixed: The refund rules are also deleted on the orders and customer d…
vishal-singh-webkul Apr 29, 2025
d4fa040
Merge branch 'develop' into gli-2561
vishal-singh-webkul May 6, 2025
d2b63e9
Merge branch 'develop' into gli-2561
vishal-singh-webkul May 7, 2025
a2714b8
Added: service related tables are not cleaned properly when using the…
vishal-singh-webkul May 8, 2025
54b595c
Cache is not cleaned after using the cleaner, which shows the old dat…
vishal-singh-webkul May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions modules/qlocleaner/qlocleaner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public function getContent()
}
Hook::exec('actionCleanData', array('method' => 'checkAndFix'));
$html .= $this->displayConfirmation($conf);
Cache::getInstance()->flush();
} elseif (Tools::isSubmit('submitCleanAndOptimize')) {
$logs = self::cleanAndOptimize();
if (count($logs)) {
Expand All @@ -95,14 +96,17 @@ public function getContent()
}
Hook::exec('actionCleanData', array('method' => 'cleanAndOptimize'));
$html .= $this->displayConfirmation($conf);
Cache::getInstance()->flush();
} elseif (Tools::getValue('submitTruncateCatalog') && Tools::getValue('checkTruncateCatalog')) {
self::truncate('catalog');
Hook::exec('actionCleanData', array('method' => 'catalog'));
$html .= $this->displayConfirmation($this->l('Catalog truncated successfuly, please run functional Integrity constraints to clean the database.'));
Cache::getInstance()->flush();
} elseif (Tools::getValue('submitTruncateSales') && Tools::getValue('checkTruncateSales')) {
self::truncate('sales');
Hook::exec('actionCleanData', array('method' => 'sales'));
$html .= $this->displayConfirmation($this->l('Orders and customers truncated successfuly, please run functional Integrity constraints to clean the database'));
Cache::getInstance()->flush();
}

$html .= $this->context->smarty->fetch(_PS_MODULE_DIR_.$this->name.'/views/templates/admin/qlocleaner_script.tpl');
Expand Down Expand Up @@ -665,7 +669,8 @@ public static function getCheckAndFixQueries()
array('warehouse_carrier', 'id_carrier', 'carrier', 'id_carrier'),
array('warehouse_product_location', 'id_product', 'product', 'id_product'),
array('warehouse_product_location', 'id_warehouse', 'warehouse', 'id_warehouse'),
array('specific_price', 'id_product', 'customer', 'id_customer'),
array('specific_price', 'id_product', 'product', 'id_product'),
array('specific_price', 'id_customer', 'customer', 'id_customer'),
array('specific_price', 'id_group', 'group', 'id_group'),
array('htl_features_block_data_lang', 'id_features_block', 'htl_features_block_data', 'id_features_block'),
array('cart_rule', 'id_customer', 'customer', 'id_customer'),
Expand Down Expand Up @@ -699,13 +704,18 @@ public static function getCheckAndFixQueries()
array('profile_lang', 'id_lang', 'lang', 'id_lang'),
array('htl_access', 'id_profile', 'profile', 'id_profile'),
array('htl_access', 'id_hotel', 'htl_branch_info', 'id'),
array('htl_room_disable_dates', 'id_room_type', 'htl_room_type', 'id'),
array('htl_room_disable_dates', 'id_room_type', 'htl_room_type', 'id_product'),
array('htl_room_type_feature_pricing_lang', 'id_feature_price', 'htl_room_type_feature_pricing', 'id_feature_price'),
array('htl_room_type_feature_pricing_lang', 'id_lang', 'lang', 'id_lang'),
array('htl_order_restrict_date', 'id_hotel', 'htl_branch_info', 'id'),
array('htl_branch_refund_rules', 'id_hotel', 'htl_branch_info', 'id'),
array('htl_order_refund_rules_lang', 'id_refund_rule', 'htl_branch_refund_rules', 'id_refund_rule'),
array('htl_advance_payment', 'id_product', 'product', 'id_product'),
array('htl_order_refund_rules_lang', 'id_lang', 'lang', 'id_lang'),
array('htl_room_type_service_product', 'id_product', 'product', 'id_product'),
array('htl_room_type_service_product', 'id_element', 'product', 'id_product'),
array('htl_room_type_service_product_price', 'id_product', 'product', 'id_product'),
array('htl_room_type_service_product_price', 'id_element', 'product', 'id_product'),
)
);
}
Expand Down Expand Up @@ -802,7 +812,9 @@ public static function getCatalogRelatedTables()
'htl_room_block_data',
'htl_features_block_data',
'htl_testimonials_block_data',
'htl_room_type_global_demand'
'htl_room_type_global_demand',
'htl_room_type_service_product',
'htl_room_type_service_product_price',
)
);
}
Expand Down Expand Up @@ -854,8 +866,6 @@ public static function getSalesRelatedTables()
'htl_room_type_service_product_order_detail',
'htl_room_type_service_product_cart_detail',
'htl_hotel_service_product_cart_detail',
'htl_order_refund_rules',
'htl_order_refund_rules_lang',
);
}
}