transforms.py: Avoid setting the barrier to be a uuid object #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
added
the
stable backport potential
|
Good thing we require coverage to be 100%; otherwise we might not have noticed that the barriers are not being recombined in my first iteration of fixing this. Of course, this suggests that we really should have a test that barriers are being recombined correctly. We need to have a fix of this in the latest CKT release by the time Qiskit 1.2 is released on August 15 (roughly two months from now). The line I had not considered in my original patch was |
garrison
changed the title
Pull Request Test Coverage Report for Build 9524103161Details
💛 - Coveralls |
|
I'm going to merge this immediately so CI passes once again. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2024
* transforms.py: Convert the barrier uuid label into a string More info at Qiskit/qiskit#12581 * Fix `isinstance(label, UUID)` check (cherry picked from commit 654f02f)
garrison
added a commit
that referenced
this pull request
Jun 15, 2024
…627) * transforms.py: Convert the barrier uuid label into a string More info at Qiskit/qiskit#12581 * Fix `isinstance(label, UUID)` check (cherry picked from commit 654f02f) Co-authored-by: Jim Garrison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info at Qiskit/qiskit#12581