set language_level=3 for Cython #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not currently specify the Cython
language_level. This results in a warning from Cython 0.29 that the default is going to change fromlanguage_level=2tolanguage_level=3strin the future.As we are dropping Python 2 support in the next release, I thought we should just explicitly specify
language_level=3. This PR adds thelanguage_leveldirective at the top of each .pyx file.There was one place where
/needed to be//to maintain integer division. The rest of the changes are to the import statements and were necessary to get the files to compile under this language level.This is built on top of #434 so that the Python 2.7 test cases wouldn't be run. Only the c7c9c2f commit is new to this PR.