idwtn should allow coefficients to be set as None #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior in
idwtndoes not match the description in the docstring when any of the values in thecoeffsdictionary isNone. This PR updates the behavior to match the docstring. This also makesidwtntreatNonecoefficients in the same was asidwt2.Previously
idwtnraised an error if any coefficients were None.technically that is a change in behavior, but as it is a bug fix I don't think we should need a deprecation cycle?
closes gh-290