make PythonInterpreter::check_executable aware of windows arch
#2758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @tonybaloney I tested this pretty extensively on arm hardware with |
tonybaloney
approved these changes
Oct 7, 2025
Contributor
|
+1 This removes a lot of duplicate logic to find and filter interpreters for Windows. |
Member
Author
messense
approved these changes
Oct 7, 2025
Member
|
Feel free to release 1.9.6. |
Member
Author
|
Will do, many thanks! |
Merged
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 11, 2025
https://build.opensuse.org/request/show/1310403 by user mia + dimstar_suse - Update to 1.9.6 * Trim platform details on Windows detection gh#PyO3/maturin#2755 * Bump actions/setup-python from 5 to 6 gh#PyO3/maturin#2748 * Bump actions/setup-node from 4 to 5 gh#PyO3/maturin#2749 * make PythonInterpreter::check_executable aware of windows arch gh#PyO3/maturin#2758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2692 (try 2)
This PR proposes removing the checks in
windows_interpreter_no_buildintoPythonInterpreter::check_executable, making that the single way to resolve if an interpreter has all the information to build.We need to run that step anyway, so integrating the windows checks into it should make things more efficient.
At the same time, I also made
check_executableaware of architecture when falling back topyto search for an interpreter.Tests need moving around, I will push tomorrow.