Deterministic seeded random streams across runs #194
Conversation
| const stable_execution_task_channel_out = Channel() | ||
| const stable_execution_task_channel_in = Channel() do chan | ||
| for expr in chan | ||
| result = Core.eval(Main, expr) |
There was a problem hiding this comment.
I think QuartoNotebookWorker has its own error handling, but you may want to catch errors from this call to prevent future put!(stable_execution_task_channel_in, ...) to fail after an exception.
There was a problem hiding this comment.
Hm yes I might have to think about what to do in this case, but for normal notebook usage, barring bugs in QuartoNotebookRunner, the error handling inside the passed expressions should be sufficient (as indicated by the test suite passing). Of course it would be nicer if in case of bugs, the behavior was still somewhat robust
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
+ Coverage 51.56% 51.67% +0.11%
==========================================
Files 30 30
Lines 1280 1283 +3
==========================================
+ Hits 660 663 +3
Misses 620 620 ☔ View full report in Codecov by Sentry. |
Fixes #192