chore(workspace): #1315 PNPM workspaces #1595
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
related to #1315
Documentation
N / A
Summary of Changes
TODO
Puppeteer prerendering kind of flaky (even locally) - could be due to new version of Puppeteer dep getting installed? - I think
shamefully-hoistworked for thisTypeError: html.replace is not a function at file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:17:23 at async file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:13:16 at async Promise.all (index 0) at async asyncMap (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lib/async-utils.js:26:10) at async default (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:57:3) at async preRenderCompilationCustom (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/lifecycles/prerender.js:160:3) at async Module.runProductionBuild (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/commands/build.js:46:7) at async run (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/cli/src/index.js:12:9) /Users/owenbuckley/Workspace/project-evergreen/greenwood/www:Error: Execution context was destroyed, most likely because of a navigation.
at rewriteError (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:453:15)
at async #evaluate (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:386:60)
at async ExecutionContext.evaluate (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:274:16)
at async IsolatedWorld.evaluate (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/IsolatedWorld.js:97:16)
at async CdpFrame.evaluate (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/api/Frame.js:359:20)
at async CdpFrame.content (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/api/Frame.js:586:20)
at async CdpPage.content (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/node_modules/.pnpm/[email protected]/node_modules/puppeteer-core/lib/esm/puppeteer/api/Page.js:553:20)
at async BrowserRunner.serialize (file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/lib/browser.js:71:21)
at async file:///Users/owenbuckley/Workspace/project-evergreen/greenwood/packages/plugin-renderer-puppeteer/src/puppeteer-handler.js:13:16
at async Promise.all (index 0)
/Users/owenbuckley/Workspace/project-evergreen/greenwood/www:
validate test command (somehow pulling in other test cases?) and running loaders tests even when only running
yarn test- this seems to be an issue with PNPM and how it handles globs, still an issue even after upgrading to Mocha 11Some
HASH_REGEXrelated test cases are failing because the import name changed, likely due to a bunch of version bumps from regenerating the lock fileUpdate GitHub Actions
Scrub all references to
yarnValidate publishing w/ Lerna
update root package.json
engines?(nice to have) fix chai import