Skip to content

ESLint: Allow Map and Set in ES5 code #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2022
Merged

ESLint: Allow Map and Set in ES5 code #3328

merged 1 commit into from
Feb 10, 2022

Conversation

RunDevelopment
Copy link
Member

See this reply for context.

Briefly, IE11 partially supports Set and Map, so we should be allowed to use them throughout our code base. However, ESLint is configured to only allow ES5 code, so it rejects Set and Map as undefined variables. This PR adds an exception to our ESLint config to declare Set and Map as defined.

@RunDevelopment
Copy link
Member Author

Since this is a very small and required by #3326, I will merge this after all tests pass.

@github-actions
Copy link

No JS Changes

Generated by 🚫 dangerJS against d9984ee

@RunDevelopment RunDevelopment merged commit f545843 into PrismJS:master Feb 10, 2022
@RunDevelopment RunDevelopment deleted the eslint-map-set branch February 10, 2022 11:32
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RunDevelopment