Move ECS worker to event-based crash detection #18804
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desertaxle
changed the title
github-actions
bot
added
enhancement
- Add tests for mark_runs_as_crashed function covering: * Non-zero exit code scenarios that trigger crashed state * Zero exit code scenarios that don't trigger crashed state * None exit code scenarios that trigger crashed state * Missing task ARN early exit * Flow run not found error handling * Final and scheduled state skipping - Add tests for deregister_task_definition function covering: * Successful task definition deregistration * Missing task definition ARN early exit * Empty detail section handling - Add tests for LastStatusFilter class covering: * No filter statuses (matches all) * Single status filtering * Multiple status filtering * All valid ECS task statuses * Final states and intermediate states groupings 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
|
This pull request is stale because it has been open 14 days with no activity. To keep this pull request open remove stale label or comment. |
desertaxle
commented
Oct 5, 2025
Comment on lines
+576
to
+582
| def _observer_task_done(task: asyncio.Task[None]): | ||
| if task.cancelled(): | ||
| logger.debug("ECS observer task cancelled") | ||
| elif task.exception(): | ||
| logger.error("ECS observer task crashed", exc_info=task.exception()) | ||
| else: | ||
| logger.debug("ECS observer task completed") |
There was a problem hiding this comment.
Need to ensure the observer is restarted on exception. Otherwise messages backup in SQS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the ECS worker from a polling-based design to an event-based design. With these changes, the ECS worker will submit ECS tasks, and the ECS observer will track the execution of those ECS tasks by receiving ECS task state change events from EventBridge via SQS.
This new design will require additional setup, but it will continue to function in a limited capacity if the configured SQS queue is unavailable. The worker will log a warning if SQS is not available.
Closes #18508