[release/v7.6] Refactor: Centralize xUnit tests into reusable workflow and remove legacy verification #26488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gacy verification (PowerShell#26243) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: TravisEz13 <[email protected]>
TravisEz13
added
the
CL-BuildPackaging
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports #26243 to release/v7.6, refactoring xUnit test execution from inline CI build steps into a dedicated reusable workflow. This improves test isolation, retryability, and visibility by removing the dependency on the ci_build job and eliminating masked test failures (no more continue-on-error or -SkipFailing flags).
Key changes:
- Created new reusable workflow
.github/workflows/xunit-tests.ymlthat handles xUnit test execution independently with proper build prerequisites - Updated all three platform CI workflows (Linux, Windows, macOS) to call the new reusable workflow instead of the legacy verify_xunit action
- Removed the legacy
.github/actions/test/verify_xunitaction and xUnit test execution from the build action
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/xunit-tests.yml | New reusable workflow for xUnit tests with proper prerequisites (checkout, .NET setup, bootstrap, build, and test execution) |
| .github/workflows/linux-ci.yml | Updated to use new xunit_tests job calling reusable workflow, removed dependency on ci_build job, updated ready_to_merge dependencies |
| .github/workflows/windows-ci.yml | Updated to use new xunit_tests job calling reusable workflow, removed dependency on ci_build job, updated ready_to_merge dependencies |
| .github/workflows/macos-ci.yml | Updated to use new xunit_tests job calling reusable workflow, removed dependency on ci_build job, updated ready_to_merge dependencies |
| .github/actions/test/verify_xunit/action.yml | Removed legacy action that downloaded artifacts and verified test results |
| .github/actions/build/ci/action.yml | Removed xUnit test execution and artifact upload steps from build action |
| .github/instructions/build-configuration-guide.md | Added documentation for choosing the right build configuration (Debug, Release, CodeCoverage) with platform considerations |
| .github/instructions/workflow-prerequisites.md | Added documentation for required prerequisite steps before building (checkout, .NET setup, bootstrap) |
| .github/instructions/start-psbuild-basics.md | Added documentation for Start-PSBuild usage patterns and common parameters |
| .github/instructions/troubleshooting-builds.md | Added troubleshooting guide for common build issues (git describe errors, version issues, etc.) |
| .github/instructions/git-requirements-for-builds.md | Added documentation explaining fetch-depth and tag synchronization requirements for builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SeeminglyScience
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26243 to release/v7.6
Triggered by @TravisEz13 on behalf of @app/copilot-swe-agent
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Refactors xUnit test execution from inline CI build steps to a dedicated reusable workflow. This improves test retryability and visibility by:
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Original PR validated by CI on master branch. Backport tested by verifying:
Risk
REQUIRED: Check exactly one box.
Medium risk as this refactors the CI test infrastructure, but the changes have been validated in master for several weeks. The refactoring improves test reliability and retryability without changing test behavior. All platforms (Linux, Windows, macOS) affected, but each workflow tested independently.