Skip to content

Conversation

@mre
Copy link
Contributor

@mre mre commented Feb 4, 2025

Fix fail condition for lychee link checker:
The link checker is currently misconfigured and fails with an error message:

Run lycheeverse/[email protected]
Run curl -sLO "https://github.com/lycheeverse/lychee/releases/download/v0.13.0/lychee-v0.13.0-x86_64-unknown-linux-gnu.tar.gz"
lychee
Run /home/runner/work/_actions/lycheeverse/lychee-action/v1.8.0/entrypoint.sh
error: unexpected argument '--fail' found

  note: to pass '--fail' as a value, use '-- --fail'

Usage: lychee --format <FORMAT> --output <OUTPUT> --no-progress <--verbose...|--quiet...> <inputs>...

For more information, try '--help'.

The reason is that the syntax is incorrect. --fail is not a flag of lychee, but a parameter of lychee-action.

Description:

  • Fixes the syntax and passes fail: true to the action.
  • Removes the non-existent --fail flag

Motivation:
The misconfigured action silently ignored link checking issues.
As a consequence, some links are currently broken, but that's a separate issue.

@VisargD
Copy link
Collaborator

VisargD commented Feb 8, 2025

Hey, thanks for the PR! LGTM

@VisargD VisargD merged commit 1d31738 into Portkey-AI:main Feb 8, 2025
1 of 2 checks passed
@mre mre deleted the update-link-checker branch February 8, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants