Skip to content

fix: extend regex for valid urls extraction logic and remove dns dependency #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2024
Merged

fix: extend regex for valid urls extraction logic and remove dns dependency #852

merged 3 commits into from
Dec 28, 2024

Conversation

VisargD
Copy link
Collaborator

@VisargD VisargD commented Dec 28, 2024 •
edited
Loading

Title:

  • Fix url regex pattern and remove dns package dependency by using DNS-over-HTTP

Related Issues: (optional)

@VisargD VisargD changed the title fix: extend regex for valid urls extraction logic fix: extend regex for valid urls extraction logic and remove dns dependency Dec 28, 2024
@VisargD VisargD merged commit 7cc119c into main Dec 28, 2024
2 checks passed
@VisargD VisargD deleted the fix/valid-url-extract-logic branch December 28, 2024 10:56
@VisargD VisargD restored the fix/valid-url-extract-logic branch December 28, 2024 11:01
@VisargD VisargD deleted the fix/valid-url-extract-logic branch December 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk-portkey sk-portkey sk-portkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using 'dns' package in 'validUrls' plugin breaks Edge Deployments
2 participants
@VisargD @sk-portkey