Skip to content

Fix readme node example #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 11, 2024
Merged

Fix readme node example #387

merged 5 commits into from
Jun 11, 2024

Conversation

LOsioChico
Copy link
Contributor

Title:

  • Fixed the node example on the README.MD

Description:

  • Formatted the code based on the .prettierrc config
  • Fixed the variable name used on chat completion from "portkey" to "gateway"
  • Fixed the parameter from camelcase "maxTokens" to snake case "max_tokens"

Motivation:

  • To test the dependency quickly

@vrushankportkey vrushankportkey mentioned this pull request Jun 5, 2024
Closed
@vrushankportkey
Copy link
Collaborator

Thank you so much for pushing this fix @LOsioChico! LGTM

@vrushankportkey
Copy link
Collaborator

Fixes #347

@VisargD VisargD merged commit 3da350f into Portkey-AI:main Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrushankportkey vrushankportkey vrushankportkey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LOsioChico @vrushankportkey @VisargD