Skip to content

fix: handle error from bedrock batch status check #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle error from bedrock batch status check #1369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/providers/bedrock/getBatchOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const getModelProvider = (modelId: string) => {
else if (modelId.includes('anthropic')) provider = 'anthropic';
else if (modelId.includes('ai21')) provider = 'ai21';
else if (modelId.includes('cohere')) provider = 'cohere';
else if (modelId.includes('amazon')) provider = 'titan';
else throw new Error('Invalid model slug');
return provider;
};
Expand Down Expand Up @@ -74,6 +75,24 @@ export const BedrockGetBatchOutputRequestHandler = async ({
headers: retrieveBatchesHeaders,
});

if (!retrieveBatchesResponse.ok) {
const error = await retrieveBatchesResponse.text();
const _error = {
message: error,
param: null,
type: null,
};
Comment on lines +79 to +84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Security/Data Exposure

Issue: Error response includes raw error text which may expose internal details
Fix: Sanitize error message or use a generic message for production
Impact: Prevents leaking internal system details to clients

Suggested change
const error = await retrieveBatchesResponse.text();
const _error = {
message: error,
param: null,
type: null,
};
const error = await retrieveBatchesResponse.text();
const _error = {
message: 'Batch retrieval failed',
param: null,
type: null,
};

return new Response(
JSON.stringify({ error: _error, provider: BEDROCK }),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the exisitng format for provider errors
Bedrock error: {errorMessage}
you can use the generateErrorResponse() utility present in /providers/utils

{
status: retrieveBatchesResponse.status,
headers: {
'Content-Type': 'application/json',
},
}
);
}

const batchDetails: BedrockGetBatchResponse =
await retrieveBatchesResponse.json();
const outputFileId = batchDetails.outputDataConfig.s3OutputDataConfig.s3Uri;
Expand Down