Skip to content

Bug: Fireworks CompeleteText endpoint should propagate max_completion… #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bug: Fireworks CompeleteText endpoint should propagate max_completion… #1353

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67c3ed2
Bug: Fireworks CompeleteText endpoint should propagate max_completion…
Sep 18, 2025
ec54aba
Merge branch 'main' into ian/fireworks-text-max-completion-tokens
ianbbqzy Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/providers/fireworks-ai/complete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ export const FireworksAICompleteConfig: ProviderConfig = {
default: 16,
min: 0,
},
max_completion_tokens: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_completion_tokens is only a chat completions parameter and is not supported by OpenAI for the deprecated completions endpoint. Since the Gateway closely follows the OpenAI API spec, this is not something that we would want to add.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://platform.openai.com/docs/api-reference/completions/create

param: 'max_tokens',
default: 200,
min: 1,
},
logprobs: {
param: 'logprobs',
min: 0,
Expand Down