-
Notifications
You must be signed in to change notification settings - Fork 761
add some parameters mapping #1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -66,12 +66,10 @@ export const BedrockTitanEmbedConfig: ProviderConfig = { | |||||||||||||||||||||||||||||||||||||||||||||
param: 'inputText', | ||||||||||||||||||||||||||||||||||||||||||||||
required: false, | ||||||||||||||||||||||||||||||||||||||||||||||
transform: (params: EmbedParams): string | undefined => { | ||||||||||||||||||||||||||||||||||||||||||||||
if ( | ||||||||||||||||||||||||||||||||||||||||||||||
Array.isArray(params.input) && | ||||||||||||||||||||||||||||||||||||||||||||||
typeof params.input[0] === 'object' && | ||||||||||||||||||||||||||||||||||||||||||||||
params.input[0].text | ||||||||||||||||||||||||||||||||||||||||||||||
) { | ||||||||||||||||||||||||||||||||||||||||||||||
return params.input[0].text; | ||||||||||||||||||||||||||||||||||||||||||||||
if (Array.isArray(params.input)) { | ||||||||||||||||||||||||||||||||||||||||||||||
if (typeof params.input[0] === 'object' && params.input[0].text) | ||||||||||||||||||||||||||||||||||||||||||||||
return params.input[0].text; | ||||||||||||||||||||||||||||||||||||||||||||||
else if (typeof params.input[0] === 'string') return params.input[0]; | ||||||||||||||||||||||||||||||||||||||||||||||
} | ||||||||||||||||||||||||||||||||||||||||||||||
if (typeof params.input === 'string') return params.input; | ||||||||||||||||||||||||||||||||||||||||||||||
}, | ||||||||||||||||||||||||||||||||||||||||||||||
Comment on lines
68
to
75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Code Refactor Issue: Nested conditionals reduce readability and increase complexity.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ Resolved: Previous suggestion for flattening conditionals was not applied in this PR but remains relevant |
||||||||||||||||||||||||||||||||||||||||||||||
|
Uh oh!
There was an error while loading. Please reload this page.