Allow failures when PII guardrail fails, manage blank agents in requests #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DescriptionSummary By MatterAI
🔄 What ChangedThis pull request refines the Azure PII detection logic and cleans up test output. Specifically, it adds a null/undefined check for the 🔍 Impact of the Change
📁 Total Files Changed
🧪 Test AddedNo new tests were added in this pull request; however, existing unit tests in 🔒 Security VulnerabilitiesN/A - No new security vulnerabilities detected. The changes improve the robustness of PII handling. MotivationThe changes aim to improve the reliability and clarity of the Azure PII detection plugin by adding defensive programming for API responses and ensuring the Type of Change
How Has This Been Tested?
Screenshots (if applicable)N/A Checklist
Related IssuesN/A Tanka Poem ♫
Sequence DiagramsequenceDiagram
participant PH as PluginHandler
participant PII as PII Handler (pii.ts)
participant AZURE_API as Azure PII API
PH->>PII: handler(context, params, eventType)
activate PII
Note over PII: try-catch block for PII processing
PII->>AZURE_API: redact(documents, parameters, pluginOptions)
activate AZURE_API
AZURE_API-->>PII: response (results.documents, redactedText)
deactivate AZURE_API
alt Invalid Azure API Response
PII->>PII: Check !response?.results?.documents
PII--xPH: Throws Error('Invalid response from Azure PII API')
else Valid Response
PII->>PII: data = response.results.documents
PII->>PII: containsPII = data.some(doc => doc.entities.length > 0)
alt PII Detected (containsPII is true)
PII->>PII: verdict = false (initial PII detection)
alt Redaction Enabled (parameters.redact is true)
PII->>PII: verdict = true (after successful redaction)
PII->>PII: transformed = true
PII->>PII: setCurrentContentPart(...)
end
end
PII-->>PH: result (error, verdict, transformed)
end
deactivate PII
|
![matter-code-review[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
Comment on lines
56
to
60
| const result = await piiHandler(context, params, 'beforeRequestHook'); | ||
| console.log('result', result); | ||
| expect(result.error).toBeNull(); | ||
| expect(result.verdict).toBe(true); | ||
| expect(result.transformed).toBe(false); |
There was a problem hiding this comment.
🧹 Dead Code
Issue: Console.log statements left in test code
Fix: Remove debug console.log statements before production
Impact: Cleaner test output and better code hygiene
Suggested change
| const result = await piiHandler(context, params, 'beforeRequestHook'); | |
| console.log('result', result); | |
| expect(result.error).toBeNull(); | |
| expect(result.verdict).toBe(true); | |
| expect(result.transformed).toBe(false); | |
| const result = await piiHandler(context, params, 'beforeRequestHook'); | |
| expect(result.error).toBeNull(); | |
| expect(result.verdict).toBe(true); | |
| expect(result.transformed).toBe(false); |
Comment on lines
64
to
72
| const result = await piiHandler( | ||
| mockContext, | ||
| { ...params, redact: false }, | ||
| 'beforeRequestHook' | ||
| ); | ||
| console.log('result', result); | ||
| expect(result.error).toBeNull(); | ||
| expect(result.verdict).toBe(false); | ||
| expect(result.transformed).toBe(false); |
There was a problem hiding this comment.
🧹 Dead Code
Issue: Console.log statements left in test code
Fix: Remove debug console.log statements before production
Impact: Cleaner test output and better code hygiene
Suggested change
| const result = await piiHandler( | |
| mockContext, | |
| { ...params, redact: false }, | |
| 'beforeRequestHook' | |
| ); | |
| console.log('result', result); | |
| expect(result.error).toBeNull(); | |
| expect(result.verdict).toBe(false); | |
| expect(result.transformed).toBe(false); | |
| const result = await piiHandler( | |
| mockContext, | |
| { ...params, redact: false }, | |
| 'beforeRequestHook' | |
| ); | |
| expect(result.error).toBeNull(); | |
| expect(result.verdict).toBe(false); | |
| expect(result.transformed).toBe(false); |
Comment on lines
135
to
152
| try { | ||
| const response = await redact(documents, parameters, options); | ||
| const response = await redact(documents, parameters, pluginOptions); | ||
| data = response.results.documents; | ||
| if (parameters.redact) { | ||
| const containsPII = | ||
| data.length > 0 && data.some((doc: any) => doc.entities.length > 0); | ||
| if (containsPII) { | ||
| verdict = false; | ||
| } | ||
| if (parameters.redact && containsPII) { | ||
| const redactedData = (response.results.documents ?? []).map( | ||
| (doc: any) => doc.redactedText | ||
| ); | ||
| setCurrentContentPart(context, eventType, transformedData, redactedData); | ||
| transformed = true; | ||
| verdict = true; | ||
| } | ||
| } catch (e) { | ||
| error = e; |
There was a problem hiding this comment.
🛠️ Code Refactor
Issue: Missing error handling for malformed Azure API responses
Fix: Add validation for response structure before accessing nested properties
Impact: Prevents runtime crashes when Azure API returns unexpected response format
Suggested change
| try { | |
| const response = await redact(documents, parameters, options); | |
| const response = await redact(documents, parameters, pluginOptions); | |
| data = response.results.documents; | |
| if (parameters.redact) { | |
| const containsPII = | |
| data.length > 0 && data.some((doc: any) => doc.entities.length > 0); | |
| if (containsPII) { | |
| verdict = false; | |
| } | |
| if (parameters.redact && containsPII) { | |
| const redactedData = (response.results.documents ?? []).map( | |
| (doc: any) => doc.redactedText | |
| ); | |
| setCurrentContentPart(context, eventType, transformedData, redactedData); | |
| transformed = true; | |
| verdict = true; | |
| } | |
| } catch (e) { | |
| error = e; | |
| try { | |
| const response = await redact(documents, parameters, pluginOptions); | |
| if (!response?.results?.documents) { | |
| throw new Error('Invalid response format from Azure PII API'); | |
| } | |
| data = response.results.documents; | |
| const containsPII = | |
| data.length > 0 && data.some((doc: any) => doc.entities?.length > 0); | |
| if (containsPII) { | |
| verdict = false; | |
| } | |
| if (parameters.redact && containsPII) { | |
| const redactedData = (response.results.documents ?? []).map( | |
| (doc: any) => doc.redactedText | |
| ); | |
| setCurrentContentPart(context, eventType, transformedData, redactedData); | |
| transformed = true; | |
| verdict = true; | |
| } | |
| } catch (e) { | |
| error = e; |
narengogi
previously approved these changes
Aug 12, 2025
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
VisargD
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.