-
Notifications
You must be signed in to change notification settings - Fork 756
add few new parameters for gpt-5 #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add few new parameters for gpt-5 #1273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameter additions look good overall. Consider adding documentation and validation for the new GPT-5 parameters.
background: { | ||
param: 'background', | ||
required: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 Documentation Gap
Issue: New parameters lack JSDoc documentation explaining their purpose and expected values
Fix: Add JSDoc comments for each new parameter (background, prompt, prompt_cache_key, stream_options, user, verbosity)
Impact: Improves developer experience and API understanding
background: { | |
param: 'background', | |
required: false, | |
}, | |
background: { | |
param: 'background', | |
required: false, | |
}, |
prompt_cache_key: { | ||
param: 'prompt_cache_key', | ||
}, | ||
safety_identifier: { | ||
param: 'safety_identifier', | ||
}, | ||
verbosity: { | ||
param: 'verbosity', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Code Refactor
Issue: Inconsistent parameter structure - missing 'required' field that exists in createModelResponse.ts
Fix: Add consistent structure with required field for maintainability
Impact: Ensures consistent parameter configuration across providers
prompt_cache_key: { | |
param: 'prompt_cache_key', | |
}, | |
safety_identifier: { | |
param: 'safety_identifier', | |
}, | |
verbosity: { | |
param: 'verbosity', | |
}, | |
prompt_cache_key: { | |
param: 'prompt_cache_key', | |
required: false, | |
}, | |
safety_identifier: { | |
param: 'safety_identifier', | |
required: false, | |
}, | |
verbosity: { | |
param: 'verbosity', | |
required: false, | |
}, |
prompt_cache_key: { | ||
param: 'prompt_cache_key', | ||
}, | ||
safety_identifier: { | ||
param: 'safety_identifier', | ||
}, | ||
verbosity: { | ||
param: 'verbosity', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Code Refactor
Issue: Inconsistent parameter structure - missing 'required' field that exists in createModelResponse.ts
Fix: Add consistent structure with required field for maintainability
Impact: Ensures consistent parameter configuration across providers
prompt_cache_key: { | |
param: 'prompt_cache_key', | |
}, | |
safety_identifier: { | |
param: 'safety_identifier', | |
}, | |
verbosity: { | |
param: 'verbosity', | |
}, | |
prompt_cache_key: { | |
param: 'prompt_cache_key', | |
required: false, | |
}, | |
safety_identifier: { | |
param: 'safety_identifier', | |
required: false, | |
}, | |
verbosity: { | |
param: 'verbosity', | |
required: false, | |
}, |
No description provided.