chore: use provider options instead of mutating request body for bedr…

[VisargD]

…ock foundation model

Description

Motivation

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)

How Has This Been Tested?

• Unit Tests
• Integration Tests
• Manual Testing

Screenshots (if applicable)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Related Issues

[matter-code-review]

Description

Summary By MatterAI

🔄 What Changed

This PR simplifies the transformToProviderRequestBody function in src/services/transformToProviderRequest.ts. It removes the conditional logic that indexed providerConfig by [fn] after calling getConfig and also removes the else fallback and the subsequent !providerConfig null check. This implies that providerConfig.getConfig is now expected to return the complete and valid provider configuration directly.

🔍 Impact of the Change

This change aims to streamline the configuration retrieval process, aligning with a more direct approach where getConfig provides the final configuration object. However, the removal of the else branch and the null check introduces a potential for runtime errors if providerConfig.getConfig is not always present or if it can return null/undefined, potentially leading to TypeError exceptions.

📁 Total Files Changed

1. src/services/transformToProviderRequest.ts: Simplified provider configuration retrieval logic by removing conditional indexing and null checks.

🧪 Test Added

N/A - No new tests were added or modified in this PR.

🔒 Security Vulnerabilities

N/A - No security vulnerabilities were identified in this change.

Motivation

To improve consistency, maintainability, and type safety by centralizing provider-specific configurations within a dedicated providerOptions object, reducing direct mutation of request bodies and simplifying the retrieval of model-specific settings. This aligns with a more robust and scalable architecture for handling diverse provider integrations.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)

How Has This Been Tested?

• Unit Tests
• Integration Tests
• Manual Testing

Screenshots (if applicable)

N/A

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Related Issues

Tip

Quality Recommendations

1. Re-evaluate the removal of the else block and the if (!providerConfig) check in transformToProviderRequestBody. If providerConfig.getConfig is not always present or can return null/undefined, this could lead to runtime errors. Consider reintroducing a fallback or a robust null check.

2. Add unit tests for the transformToProviderRequestBody function, specifically covering edge cases where getConfig might not exist or return null/undefined to ensure robustness.

Tanka Poem ♫

Old paths now cleared,
New options flow with ease,
Yet, a small gap,
Ensuring all data's safe,
Prevents the silent crash.

Sequence Diagram

sequenceDiagram
    participant Client as Request Client
    participant T as transformToProviderRequestBody
    participant PC as ProviderConfigs[provider]
    participant GC as providerConfig.getConfig
    participant RT as providerConfig.requestTransforms[fn]

    Client->>T: Call transformToProviderRequestBody(requestBody, requestHeaders, provider, fn, providerOptions)
    T->>PC: Get initial providerConfig (ProviderConfigs[provider])
    alt If providerConfig.getConfig exists
        T->>GC: Call getConfig({ params: {}, providerOptions })
        GC-->>T: Returns updated providerConfig (full config object)
    end
    T->>RT: Call requestTransforms[fn](requestBody, requestHeaders)
    RT-->>T: Returns transformed request body
    T-->>Client: Return transformed request body

Loading

[matter-code-review]

This PR makes a good architectural improvement by using provider options instead of mutating the request body directly.

[matter-code-review]

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

• /matter summary: Generate AI Summary for the PR
• /matter review: Generate AI Reviews for the latest commit in the PR
• /matter review-full: Generate AI Reviews for the complete PR
• /matter release-notes: Generate AI release-notes for the PR
• /matter : Chat with your PR with Matter AI Agent
• /matter remember : Generate AI memories for the PR
• /matter explain: Get an explanation of the PR
• /matter help: Show the list of available commands and documentation
• Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

[matter-code-review]

Important

PR Review Skipped

PR review skipped as per the configuration setting. Run a manually review by commenting /matter review

💡Tips to use Matter AI

Command List

• /matter summary: Generate AI Summary for the PR
• /matter review: Generate AI Reviews for the latest commit in the PR
• /matter review-full: Generate AI Reviews for the complete PR
• /matter release-notes: Generate AI release-notes for the PR
• /matter : Chat with your PR with Matter AI Agent
• /matter remember : Generate AI memories for the PR
• /matter explain: Get an explanation of the PR
• /matter help: Show the list of available commands and documentation
• Need help? Join our Discord server: https://discord.gg/fJU5DvanU3

[VisargD]

/matter review

[matter-code-review]

This PR looks good. It properly refactors the code to use provider options instead of mutating the request body.