fix: stream cache response mapping

[VisargD]

Description

Caching fix on top of #1121

Motivation

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)

How Has This Been Tested?

• Unit Tests
• Integration Tests
• Manual Testing

Screenshots (if applicable)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Related Issues

[matter-code-review]

Summary By MatterAI

🔄 What Changed

Added isResponseAlreadyMapped: false property to the response object in the cache handling logic within handlerUtils.ts. This ensures proper stream cache response mapping.

🔍 Impact of the Change

This fix addresses an issue with stream cache response mapping by explicitly setting the isResponseAlreadyMapped flag to false. This ensures that cached responses are properly processed through the mapping pipeline when retrieved from cache.

📁 Total Files Changed

• src/handlers/handlerUtils.ts: Added isResponseAlreadyMapped: false property to the response object for cache handling.

🧪 Test Added

N/A - No explicit tests were added in this PR.

🔒 Security Vulnerabilities

N/A - No security vulnerabilities were introduced or addressed in this change.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)

How Has This Been Tested?

• Unit Tests
• Integration Tests
• Manual Testing

Screenshots (if applicable)

N/A

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Related Issues

Related to stream cache response handling

Tip

Quality Recommendations

1. Add a unit test to verify the cache response mapping behavior with the new flag

2. Consider adding a comment explaining why isResponseAlreadyMapped needs to be explicitly set to false

Sequence Diagram

sequenceDiagram
    participant Client
    participant Gateway
    participant CacheHandler
    participant ResponseProcessor
    
    Client->>Gateway: Request API endpoint
    Gateway->>CacheHandler: Check cache for response
    Note over CacheHandler: Cache hit found
    
    CacheHandler->>ResponseProcessor: Process cached response
    Note over CacheHandler: Before fix: Missing isResponseAlreadyMapped flag
    Note over CacheHandler: After fix: Added isResponseAlreadyMapped: false
    
    ResponseProcessor->>ResponseProcessor: Map response based on isResponseAlreadyMapped flag
    ResponseProcessor->>Gateway: Return properly mapped response
    Gateway->>Client: Return API response

Loading

[matter-code-review]

This PR adds the isResponseAlreadyMapped: false flag to the cache response object, which is a good fix for ensuring proper stream cache response mapping. The change is minimal and focused on addressing a specific issue.