Skip to content

Fix/cohere embed handle null encoding format #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025
Merged

Fix/cohere embed handle null encoding format #1213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3f0ac0
handle null in encoding format
narengogi Jul 7, 2025
d090667
handle null in encoding format
narengogi Jul 7, 2025
542d4ac
Merge branch 'main' into fix/cohere-embed-handle-null-encoding-format
VisargD Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/providers/bedrock/embed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ export const BedrockCohereEmbedConfig: ProviderConfig = {
encoding_format: {
param: 'embedding_types',
required: false,
transform: (params: any): string[] => {
transform: (params: any): string[] | undefined => {
if (Array.isArray(params.encoding_format)) return params.encoding_format;
return [params.encoding_format];
else if (typeof params.encoding_format === 'string')
return [params.encoding_format];
},
},
};
Expand Down Expand Up @@ -115,9 +116,10 @@ export const BedrockTitanEmbedConfig: ProviderConfig = {
encoding_format: {
param: 'embeddingTypes',
required: false,
transform: (params: any): string[] => {
transform: (params: any): string[] | undefined => {
if (Array.isArray(params.encoding_format)) return params.encoding_format;
return [params.encoding_format];
else if (typeof params.encoding_format === 'string')
return [params.encoding_format];
},
},
// Titan specific parameters
Expand Down
5 changes: 3 additions & 2 deletions src/providers/cohere/embed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ export const CohereEmbedConfig: ProviderConfig = {
encoding_format: {
param: 'embedding_types',
required: false,
transform: (params: any): string[] => {
transform: (params: any): string[] | undefined => {
if (Array.isArray(params.encoding_format)) return params.encoding_format;
return [params.encoding_format];
else if (typeof params.encoding_format === 'string')
return [params.encoding_format];
},
},
//backwards compatibility
Expand Down