feat: improve support for the DashScope provider #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `enable_search`, and can invoke a rerank model.
|
DescriptionSummary By MatterAI
🔄 What Changed
🔍 Impact of the Change
📁 Total Files Changed
🧪 Test AddedN/A 🔒Security VulnerabilitiesN/A MotivationThis PR enhances the DashScope provider by updating its API configuration to align with new service endpoints and removing deprecated or unused functionality. Type of Change
How Has This Been Tested?
Screenshots (if applicable)N/A Checklist
Related IssuesN/A Tip Quality Recommendations
Tanka Poem ♫
Sequence DiagramsequenceDiagram
participant App as Application
participant DashScopeAPIConfig as DashScope API Config
participant DashScopeService as DashScope Service
participant DashScopeExternal as DashScope External API
App->>DashScopeService: callChatComplete(params)
DashScopeService->>DashScopeAPIConfig: getBaseURL()
DashScopeAPIConfig-->>DashScopeService: "https://dashscope-intl.aliyuncs.com/compatible-mode/v1"
DashScopeService->>DashScopeAPIConfig: getEndpoint("chatComplete")
DashScopeAPIConfig-->>DashScopeService: "/chat/completions"
DashScopeService->>DashScopeExternal: POST /compatible-mode/v1/chat/completions (with new base URL)
DashScopeExternal-->>DashScopeService: chatResponse
App->>DashScopeService: callEmbed(params)
DashScopeService->>DashScopeAPIConfig: getBaseURL()
DashScopeAPIConfig-->>DashScopeService: "https://dashscope-intl.aliyuncs.com/compatible-mode/v1"
DashScopeService->>DashScopeAPIConfig: getEndpoint("embed")
DashScopeAPIConfig-->>DashScopeService: "/embeddings"
DashScopeService->>DashScopeExternal: POST /compatible-mode/v1/embeddings (with new base URL)
DashScopeExternal-->>DashScopeService: embedResponse
Note over DashScopeAPIConfig: Rerank functionality removed
Note over DashScopeService: No longer supports rerank calls
|
![matter-code-review[bot]](https://avatars.githubusercontent.com/in/474549?s=60&v=4){kind=small}
narengogi
requested changes
Jul 1, 2025
narengogi
reviewed
Jul 7, 2025
narengogi
reviewed
Aug 4, 2025
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
|
Hi @narengogi, Apologies for the long delay on this. I got a bit sidetracked with some other work. I believe I've already responded to your comment about removing the I've now made the requested changes and moved the |
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
narengogi
approved these changes
Aug 28, 2025
|
Important PR Review SkippedPR review skipped as per the configuration setting. Run a manually review by commenting /matter review 💡Tips to use Matter AICommand List
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the DashScope provider by adding support for new features documented in the official guide(zh,en).
Key Updates:
Support for new parameters, including
enable_searchandenable_thinking.Integration of the rerank API.
Motivation
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Checklist
Related Issues